Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] Comments on Experiments and examples JOSS paper #145

Closed
3 tasks done
tmigot opened this issue Aug 6, 2024 · 3 comments
Closed
3 tasks done

[ADD] Comments on Experiments and examples JOSS paper #145

tmigot opened this issue Aug 6, 2024 · 3 comments
Labels
new feature Additional feature to be added

Comments

@tmigot
Copy link

tmigot commented Aug 6, 2024

🚀 Feature Request

Suggestions regarding the Experiments and examples section of the paper submitted to JOSS :

  • The (Ben Hamner, Friedman, 2013) citation seems to be very Kaggle specific (for instance I didn't find a correspondance on Google Scholar), so could you add on the reference to add the link to the data. Kaggle website suggests:
Adam, Ben Hamner, Dan Friedman, SSA_Expedia. (2013). Personalize Expedia Hotel Searches - ICDM 2013. Kaggle. https://kaggle.com/competitions/expedia-personalized-sort

In general having links for each reference is a good practice in such journal.

  • Is there a notebook somewhere on this repo that shows the code used to generate this benchmark? If so, I would add the link to it in a footnote of the paper or at least a comment that it is in the repository. There is a lot of content here (congrat's!), but it would really help the reader to find its way.
  • The "customize choice models" is indeed a nice feature, however I'm not sure it is necessary to show code regarding this in the paper. It is probably sufficient to just mention it and link to the documentation of the package.

📎 Additional context

This comment are here to ensure data is accessible and reproducibility.

Connected to openjournals/joss-reviews#6899

@tmigot tmigot added the new feature Additional feature to be added label Aug 6, 2024
@VincentAuriau
Copy link
Collaborator

Hello @tmigot,
Thank you for your review !

  • Here are two notebooks for the different experiments (benchmark + custom model)
  • I will modify the paper following your recommendations.

@VincentAuriau
Copy link
Collaborator

Hello,
I fixed the the citation and removed the example, while adding a sentence earlier in the paper to link the documentation !

@tmigot
Copy link
Author

tmigot commented Aug 11, 2024

thanks @VincentAuriau

@tmigot tmigot closed this as completed Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Additional feature to be added
Projects
None yet
Development

No branches or pull requests

2 participants