Unable to create AMQ Statefulset when using the same SSL secret on different acceptors

[ammachado]

Describe the bug
The StatefulSet created by the operator does not run because the operator creates a duplicate volume mounting the acceptors' SSL secret

To Reproduce
Steps to reproduce the behavior:

1. Create an ActiveMQArtemis instance with two acceptors with SSL enabled using the same SSL secret

Platform (please complete the following information):

• Openshift 4.10
• Latest operator version

Expected behavior
Expected to have an AMQ instance running

Screenshots
Optional, add screenshots to help explain your problem.

Additional context
Can be duplicated using this manifest:

apiVersion: broker.amq.io/v1beta1
kind: ActiveMQArtemis
metadata:
  name: amq-demo
  application: amq-demo-app
  namespace: amq-demo
spec:
  acceptors:
    - name: all-61617
      needClientAuth: false
      port: 61617
      protocols: all
      sslEnabled: true
      sslSecret: amq-demo-ssl-secret
      verifyHost: false
      wantClientAuth: false
    - name: amqp-5671
      needClientAuth: false
      port: 5671
      protocols: all
      sslEnabled: true
      sslSecret: amq-demo-ssl-secret
      verifyHost: false
      wantClientAuth: false
  adminPassword: admin
  adminUser: admin
  console:
    expose: true
  deploymentPlan:
    image: placeholder
    size: 2
    requireLogin: false
    persistenceEnabled: false
    journalType: nio
    messageMigration: false
    jolokiaAgentEnabled: false
    managementRBACEnabled: true

[ammachado]

Duplicate of #267

[bergner]

This was closed as duplicate but is still an issue as far as I can tell. In Openshift 4.10 it fails when the same "sslSecret" is referenced by an acceptor and the console. I looked at the latest in the master branch and activemqartemis_reconciler.go is still only appending volume definitions, without anything that looks like duplicate checks.

I ended up doing the following on Openshift:

1. Extract the Openshift router wildcard certificate and key (for the *.apps.domain), also extract the Openshift CA certificate
2. Package Openshift router certificate and key as a Java keystore
3. Similarly package Openshift CA cert as a Java truststore
4. Save 2+3 above in two different Openshift secrets, one for the acceptor and one for the console, and use key naming conventions used by Artemis operator (broker.ks + keyStorePassword and client.ts + trustStorePassword)