From 92c587b55012df464fbb058d2c7c4124d94895f0 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 29 Sep 2023 21:11:02 +0000 Subject: [PATCH 1/2] chore(deps): bump the actions group with 2 updates Bumps the actions group with 2 updates: [actions/checkout](https://github.com/actions/checkout) and [actions/setup-node](https://github.com/actions/setup-node). Updates `actions/checkout` from 3 to 4 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](https://github.com/actions/checkout/compare/v3...v4) Updates `actions/setup-node` from 3.6.0 to 3.8.1 - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](https://github.com/actions/setup-node/compare/v3.6.0...v3.8.1) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions ... Signed-off-by: dependabot[bot] --- .github/workflows/check-dist.yml | 4 ++-- .github/workflows/test.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/check-dist.yml b/.github/workflows/check-dist.yml index adbe184..8df3da2 100644 --- a/.github/workflows/check-dist.yml +++ b/.github/workflows/check-dist.yml @@ -21,10 +21,10 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Set Node.js 16.x - uses: actions/setup-node@v3.6.0 + uses: actions/setup-node@v3.8.1 with: node-version: 16.x cache: npm diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index ab080c2..1c38c62 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -10,7 +10,7 @@ jobs: build: # make sure build/ci work properly runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - run: npm install - run: npm run lint - run: npm run format-check @@ -19,7 +19,7 @@ jobs: test: # make sure the action works on a clean machine without building runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Test invalid JSON id: json continue-on-error: true From a8a0ae51b68c0d633476b15b707a5f3868094950 Mon Sep 17 00:00:00 2001 From: Matt Loberg Date: Fri, 29 Sep 2023 16:14:22 -0500 Subject: [PATCH 2/2] ci(check-dist): grab node version from package.json --- .github/workflows/check-dist.yml | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/.github/workflows/check-dist.yml b/.github/workflows/check-dist.yml index 8df3da2..cc4466b 100644 --- a/.github/workflows/check-dist.yml +++ b/.github/workflows/check-dist.yml @@ -3,7 +3,7 @@ # `index.js` is the code that will run. # For our project, we generate this file through a build process from other source files. # We need to make sure the checked-in `index.js` actually matches what we expect it to be. -name: Check dist/ +name: Check dist on: push: @@ -19,34 +19,26 @@ on: jobs: check-dist: runs-on: ubuntu-latest - steps: - uses: actions/checkout@v4 - - - name: Set Node.js 16.x - uses: actions/setup-node@v3.8.1 + - uses: actions/setup-node@v3 with: - node-version: 16.x + node-version-file: package.json + check-latest: true cache: npm - - - name: Install dependencies - run: npm ci - + - run: npm ci - name: Rebuild the dist/ directory run: | npm run build npm run package - - name: Compare the expected and actual dist/ directories + id: diff run: | if [ "$(git diff --ignore-space-at-eol dist/ | wc -l)" -gt "0" ]; then echo "Detected uncommitted changes after build. See status below:" git diff exit 1 fi - id: diff - - # If index.js was different than expected, upload the expected version as an artifact - uses: actions/upload-artifact@v3 if: ${{ failure() && steps.diff.conclusion == 'failure' }} with: