Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DDL] Standing up BuildCreateTableSQL #1033

Merged
merged 5 commits into from
Nov 12, 2024
Merged

[DDL] Standing up BuildCreateTableSQL #1033

merged 5 commits into from
Nov 12, 2024

Conversation

Tang8330
Copy link
Contributor

@Tang8330 Tang8330 commented Nov 12, 2024 •
edited
Loading

Standing up BuildCreateTableSQL so it's more modular

  • Easier to test
  • No massive struct
  • Ability to import BuildCreateTableSQL into Reader

@Tang8330 Tang8330 changed the title [DDL] Standing up CreateTable [DDL] Standing up BuildCreateTableSQL Nov 12, 2024
@Tang8330 Tang8330 marked this pull request as ready for review November 12, 2024 18:23
@Tang8330 Tang8330 requested a review from a team as a code owner November 12, 2024 18:23
@Tang8330 Tang8330 merged commit 69b26a8 into master Nov 12, 2024
3 checks passed
@Tang8330 Tang8330 deleted the refactor-ddl-create-table branch November 12, 2024 21:49
@Tang8330 Tang8330 mentioned this pull request Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathan-artie nathan-artie nathan-artie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tang8330 @nathan-artie