Add an identify command #FF
#7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haha I think Circle is lying to us about all that 🍏 |
joeyAghion
changed the title
identify commandidentify command #FF
anandaroop
changed the title
identify command #FFidentify command #FF
anandaroop
commented
Sep 1, 2019
| .get("/api/v1/artwork/abc123") | ||
| .reply(200) | ||
| .get("/api/v1/partner/abc123") | ||
| .reply(404) |
There was a problem hiding this comment.
The second arg to .reply could be an object representing the JSON response. But here we mainly care whether the request 404'd or not.
| }) | ||
|
|
||
| const gravityResponses = await Promise.all(gravityPromises) | ||
| const foundIndex = gravityResponses.findIndex(r => r.status === 200) |
There was a problem hiding this comment.
The strategy here is to build up all the requests for the various collections, fire em off all at once, and look for one that succeeded.
|
Ok just had to update an assumption about the Gravity urls based on what @pepopowitz did over on #8. |
|
🚀 PR was released in v0.0.4 🚀 |
1 similar comment
|
🚀 PR was released in v0.0.4 🚀 |
|
🚀 PR was released in v0.0.4 🚀 |
2 similar comments
|
🚀 PR was released in v0.0.4 🚀 |
|
🚀 PR was released in v0.0.4 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
identifycommand to identify an Artist, Artwork or Partner based on its BSON id. This also demonstrates the oclif way of mocking network requests in the accompanying test.Still supplying the token as an env var, till we get logins wired up.