This repository has been archived by the owner on Mar 12, 2020. It is now read-only.
[Shows] Fixed bug where current and upcoming shows were not properly wrapping #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,11 +44,11 @@ class Shows extends React.Component { | |||
|
|
|||
| currentAndUpcomingList() { | |||
| if (this.props.artist.current_shows.length || this.props.artist.upcoming_shows.length) { | |||
| const shows = [].concat.apply([], [this.props.artist.current_shows, this.props.artist.upcoming_shows]); | |||
There was a problem hiding this comment.
If they're in separate lists, the wrapping is off and the view will start a new row for upcoming shows. This way, we have one container for all Current & Upcoming shows.
sarahscott
changed the title
sarahscott
changed the title
|
Do I need to worry about the dependency check? |
|
Nope, I already checked them https://github.com/dependencyci/support/issues/1 |
|
Awesome! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this problem:
So our Current & Upcoming list looks like this instead: