From e6e2648d6e783ec0f2148cab9ca5b29e7471508b Mon Sep 17 00:00:00 2001 From: Christopher Pappas Date: Fri, 14 Aug 2020 15:49:37 -0700 Subject: [PATCH] Update review app docs --- docs/creating_review_app.md | 13 +++++++++++++ package.json | 1 + 2 files changed, 14 insertions(+) diff --git a/docs/creating_review_app.md b/docs/creating_review_app.md index cdd8e9dd6ad..cd6470a1771 100644 --- a/docs/creating_review_app.md +++ b/docs/creating_review_app.md @@ -36,6 +36,19 @@ CircleCI will match the `review-app-` prefix and either: 1. Create a review app using `build_review_app.sh` if the review app doesn't exist yet (i.e. first successful push of the branch), or 2. Update an existing review app using `update_review_app.sh` +3. Once CI is complete follow [this step](https://github.com/artsy/force/blob/master/docs/creating_review_app.md#dns-setup) to setup DNS. + +> Once you're done working with the review app it (currently) has to be deleted manually + +#### Deleting a Review App + +Run: + +```sh +yarn delete-review-app +``` + +The `name` is the name of the branch, minus the `review-app-` prefix. #### Manual Steps diff --git a/package.json b/package.json index ee46a7a11a9..f7e7f345975 100644 --- a/package.json +++ b/package.json @@ -20,6 +20,7 @@ "compile": "babel src/v2 --out-dir dist/v2 -s --source-map --extensions '.js,.jsx,.ts,.tsx' --ignore src/v2/**/__tests__,src/v2/**/__stories__", "cypress:run": "./node_modules/.bin/cypress run", "cypress": "./node_modules/.bin/cypress open", + "delete-review-app": "kubectl --context staging delete namespace", "jest": "JEST_JUNIT_OUTPUT=reports/junit/js-test-results.xml node --expose-gc --max_old_space_size=4096 ./node_modules/.bin/jest --no-cache --runInBand --logHeapUsage", "lint": "eslint --cache --cache-location '.cache/eslint/' --ext ts,tsx --ignore-pattern 'src/v2/__generated__'", "mocha": "scripts/mocha.sh",