From f2f4d1af915b094c701cfc7f6a10560f821e5574 Mon Sep 17 00:00:00 2001 From: Ozzie Vasdi <29984068+ovasdi@users.noreply.github.com> Date: Mon, 22 May 2023 11:03:00 -0400 Subject: [PATCH 1/3] Revert "Revert "chore: remove set-ouptut GHA workflow commands"" This reverts commit 5c13a317aa7e165b23c2c13362b0e7b0a18ff92b. --- .github/workflows/next-on-call.yml | 6 +++--- .github/workflows/open-rfcs.yml | 4 ++-- .github/workflows/recently-published.yml | 6 +++--- .github/workflows/standup-reminder.yml | 6 +++--- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/next-on-call.yml b/.github/workflows/next-on-call.yml index 6b02afd..459dea4 100644 --- a/.github/workflows/next-on-call.yml +++ b/.github/workflows/next-on-call.yml @@ -21,7 +21,7 @@ jobs: - name: Run CLI id: cli - run: echo "::set-output name=payload::$(artsy scheduled:next-on-call)" + run: echo "PAYLOAD=$(artsy scheduled:next-on-call)" >> $GITHUB_OUTPUT env: OPSGENIE_API_KEY: ${{ secrets.OPSGENIE_API_KEY }} SLACK_WEB_API_TOKEN: ${{ secrets.SLACK_WEB_API_TOKEN }} @@ -30,6 +30,6 @@ jobs: uses: 8398a7/action-slack@v3 with: status: custom - custom_payload: ${{steps.cli.outputs.payload}} + custom_payload: ${{steps.cli.outputs.PAYLOAD}} env: - SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} \ No newline at end of file + SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} diff --git a/.github/workflows/open-rfcs.yml b/.github/workflows/open-rfcs.yml index 9148f5e..698838b 100644 --- a/.github/workflows/open-rfcs.yml +++ b/.github/workflows/open-rfcs.yml @@ -21,7 +21,7 @@ jobs: - name: Run CLI id: cli - run: echo "::set-output name=payload::$(artsy scheduled:rfcs)" + run: echo "PAYLOAD=$(artsy scheduled:rfcs)" >> $GITHUB_PAYLOAD env: GITHUB_TOKEN: ${{ secrets.GH_TOKEN }} @@ -29,6 +29,6 @@ jobs: uses: 8398a7/action-slack@v3 with: status: custom - custom_payload: ${{steps.cli.outputs.payload}} + custom_payload: ${{steps.cli.outputs.PAYLOAD}} env: SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} diff --git a/.github/workflows/recently-published.yml b/.github/workflows/recently-published.yml index 9fe58c3..ec62f4b 100644 --- a/.github/workflows/recently-published.yml +++ b/.github/workflows/recently-published.yml @@ -21,7 +21,7 @@ jobs: - name: Run CLI id: cli - run: echo "::set-output name=payload::$(artsy scheduled:recently-published)" + run: echo "PAYLOAD=$(artsy scheduled:recently-published)" >> $GITHUB_PAYLOAD env: SLACK_WEB_API_TOKEN: ${{ secrets.SLACK_WEB_API_TOKEN }} @@ -29,6 +29,6 @@ jobs: uses: 8398a7/action-slack@v3 with: status: custom - custom_payload: ${{steps.cli.outputs.payload}} + custom_payload: ${{steps.cli.outputs.PAYLOAD}} env: - SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} \ No newline at end of file + SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} diff --git a/.github/workflows/standup-reminder.yml b/.github/workflows/standup-reminder.yml index 5ef59b8..f309588 100644 --- a/.github/workflows/standup-reminder.yml +++ b/.github/workflows/standup-reminder.yml @@ -21,7 +21,7 @@ jobs: - name: Run CLI id: cli - run: echo "::set-output name=payload::$(artsy scheduled:standup-reminder)" + run: echo "PAYLOAD=$(artsy scheduled:standup-reminder)" >> $GITHUB_PAYLOAD env: OPSGENIE_API_KEY: ${{ secrets.OPSGENIE_API_KEY }} SLACK_WEB_API_TOKEN: ${{ secrets.SLACK_WEB_API_TOKEN }} @@ -30,6 +30,6 @@ jobs: uses: 8398a7/action-slack@v3 with: status: custom - custom_payload: ${{steps.cli.outputs.payload}} + custom_payload: ${{steps.cli.outputs.PAYLOAD}} env: - SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} \ No newline at end of file + SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} From f4116fe94fbde79bdb3d995fce2ea980c564f161 Mon Sep 17 00:00:00 2001 From: Ozzie Vasdi <29984068+ovasdi@users.noreply.github.com> Date: Mon, 22 May 2023 11:05:10 -0400 Subject: [PATCH 2/3] fix: typo in environment variable --- .github/workflows/open-rfcs.yml | 2 +- .github/workflows/recently-published.yml | 2 +- .github/workflows/standup-reminder.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/open-rfcs.yml b/.github/workflows/open-rfcs.yml index 698838b..15860f6 100644 --- a/.github/workflows/open-rfcs.yml +++ b/.github/workflows/open-rfcs.yml @@ -21,7 +21,7 @@ jobs: - name: Run CLI id: cli - run: echo "PAYLOAD=$(artsy scheduled:rfcs)" >> $GITHUB_PAYLOAD + run: echo "PAYLOAD=$(artsy scheduled:rfcs)" >> $GITHUB_OUTPUT env: GITHUB_TOKEN: ${{ secrets.GH_TOKEN }} diff --git a/.github/workflows/recently-published.yml b/.github/workflows/recently-published.yml index ec62f4b..6db310c 100644 --- a/.github/workflows/recently-published.yml +++ b/.github/workflows/recently-published.yml @@ -21,7 +21,7 @@ jobs: - name: Run CLI id: cli - run: echo "PAYLOAD=$(artsy scheduled:recently-published)" >> $GITHUB_PAYLOAD + run: echo "PAYLOAD=$(artsy scheduled:recently-published)" >> $GITHUB_OUTPUT env: SLACK_WEB_API_TOKEN: ${{ secrets.SLACK_WEB_API_TOKEN }} diff --git a/.github/workflows/standup-reminder.yml b/.github/workflows/standup-reminder.yml index f309588..c8dd050 100644 --- a/.github/workflows/standup-reminder.yml +++ b/.github/workflows/standup-reminder.yml @@ -21,7 +21,7 @@ jobs: - name: Run CLI id: cli - run: echo "PAYLOAD=$(artsy scheduled:standup-reminder)" >> $GITHUB_PAYLOAD + run: echo "PAYLOAD=$(artsy scheduled:standup-reminder)" >> $GITHUB_OUTPUT env: OPSGENIE_API_KEY: ${{ secrets.OPSGENIE_API_KEY }} SLACK_WEB_API_TOKEN: ${{ secrets.SLACK_WEB_API_TOKEN }} From 9706b677441e49393e9a098f9e75aef3ed63cceb Mon Sep 17 00:00:00 2001 From: Ozzie Vasdi <29984068+ovasdi@users.noreply.github.com> Date: Mon, 22 May 2023 11:19:52 -0400 Subject: [PATCH 3/3] refactor: wrap GITHUB_OUTPUT env var in double quotes --- .github/workflows/facilitate-incident-review.yml | 2 +- .github/workflows/next-on-call.yml | 2 +- .github/workflows/open-rfcs.yml | 2 +- .github/workflows/recently-published.yml | 2 +- .github/workflows/standup-reminder.yml | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/facilitate-incident-review.yml b/.github/workflows/facilitate-incident-review.yml index 68cccc2..e23e715 100644 --- a/.github/workflows/facilitate-incident-review.yml +++ b/.github/workflows/facilitate-incident-review.yml @@ -21,7 +21,7 @@ jobs: - name: Run CLI id: cli - run: echo "PAYLOAD=$(artsy scheduled:facilitate-incident-review --useDatesVar)" >> $GITHUB_OUTPUT + run: echo "PAYLOAD=$(artsy scheduled:facilitate-incident-review --useDatesVar)" >> "$GITHUB_OUTPUT" env: OPSGENIE_API_KEY: ${{ secrets.OPSGENIE_API_KEY }} SLACK_WEB_API_TOKEN: ${{ secrets.SLACK_WEB_API_TOKEN }} diff --git a/.github/workflows/next-on-call.yml b/.github/workflows/next-on-call.yml index 459dea4..bb4a848 100644 --- a/.github/workflows/next-on-call.yml +++ b/.github/workflows/next-on-call.yml @@ -21,7 +21,7 @@ jobs: - name: Run CLI id: cli - run: echo "PAYLOAD=$(artsy scheduled:next-on-call)" >> $GITHUB_OUTPUT + run: echo "PAYLOAD=$(artsy scheduled:next-on-call)" >> "$GITHUB_OUTPUT" env: OPSGENIE_API_KEY: ${{ secrets.OPSGENIE_API_KEY }} SLACK_WEB_API_TOKEN: ${{ secrets.SLACK_WEB_API_TOKEN }} diff --git a/.github/workflows/open-rfcs.yml b/.github/workflows/open-rfcs.yml index 15860f6..00742b7 100644 --- a/.github/workflows/open-rfcs.yml +++ b/.github/workflows/open-rfcs.yml @@ -21,7 +21,7 @@ jobs: - name: Run CLI id: cli - run: echo "PAYLOAD=$(artsy scheduled:rfcs)" >> $GITHUB_OUTPUT + run: echo "PAYLOAD=$(artsy scheduled:rfcs)" >> "$GITHUB_OUTPUT" env: GITHUB_TOKEN: ${{ secrets.GH_TOKEN }} diff --git a/.github/workflows/recently-published.yml b/.github/workflows/recently-published.yml index 6db310c..d15147d 100644 --- a/.github/workflows/recently-published.yml +++ b/.github/workflows/recently-published.yml @@ -21,7 +21,7 @@ jobs: - name: Run CLI id: cli - run: echo "PAYLOAD=$(artsy scheduled:recently-published)" >> $GITHUB_OUTPUT + run: echo "PAYLOAD=$(artsy scheduled:recently-published)" >> "$GITHUB_OUTPUT" env: SLACK_WEB_API_TOKEN: ${{ secrets.SLACK_WEB_API_TOKEN }} diff --git a/.github/workflows/standup-reminder.yml b/.github/workflows/standup-reminder.yml index c8dd050..eb8f770 100644 --- a/.github/workflows/standup-reminder.yml +++ b/.github/workflows/standup-reminder.yml @@ -21,7 +21,7 @@ jobs: - name: Run CLI id: cli - run: echo "PAYLOAD=$(artsy scheduled:standup-reminder)" >> $GITHUB_OUTPUT + run: echo "PAYLOAD=$(artsy scheduled:standup-reminder)" >> "$GITHUB_OUTPUT" env: OPSGENIE_API_KEY: ${{ secrets.OPSGENIE_API_KEY }} SLACK_WEB_API_TOKEN: ${{ secrets.SLACK_WEB_API_TOKEN }}