Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peril running same check multiple times / spellchecking deleted code #56

Open
izakp opened this issue May 17, 2018 · 2 comments
Open

Peril running same check multiple times / spellchecking deleted code #56

izakp opened this issue May 17, 2018 · 2 comments
Assignees

Comments

@izakp
Copy link
Contributor

izakp commented May 17, 2018

When creating this PR: https://github.com/artsy/gravity/pull/11733 Peril:

  • Ran the same spellcheck 5 times and left 5 identical comments
  • Spellchecked deleted sections of code
@orta
Copy link
Contributor

orta commented May 17, 2018

Nice idea on not making it spellcheck deleted section of code

@orta
Copy link
Contributor

orta commented May 22, 2018

I wonder if it's spellchecking the head repo instead of the base, and that I haven't noticed it because I use a branches not forks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants