Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Babel Pipeline, Better ESLint #1224

Merged
merged 2 commits into from
Aug 14, 2017
Merged

Conversation

damassi
Copy link
Member

@damassi damassi commented Aug 14, 2017

This PR adds Babel to the flow, along with some common packages as taken from Force:

  • babel-cli
  • babel-plugin-inline-react-svg
  • babel-plugin-module-resolver
  • babel-plugin-rewire
  • babel-plugin-styled-components
  • babel-plugin-transform-class-properties
  • babel-plugin-transform-runtime
  • babel-preset-es2015
  • babel-preset-react
  • babel-preset-stage-3

Notable items from above:

  • Updates ESLint setup to follow what we have on Force, with standard and standard-react being the primary engines.
  • In React code, .svg file imports are automatically converted into components that you can use like so: <Icon />
  • Modules written in JS can take advantage of absolute path imports -- e.g., import baz from 'api/foo/bar/baz'
  • Similar to Force, rewrite for test code
  • I know most component work is taking place in reaction, but I want to setup server-side react rendering and this, similar to force, is needed to pluck those styles out

@damassi damassi requested a review from eessex August 14, 2017 18:34
@damassi damassi changed the title Add Babel Pipeline Add Babel Pipeline, Better ESLint Aug 14, 2017
@damassi damassi force-pushed the add-babel-pipeline branch from bc752dc to 109983b Compare August 14, 2017 20:25
env('./.env')
}

require('./boot')
Copy link
Member Author

@damassi damassi Aug 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created this boot loader so that from the point of ./boot onwards we can write ES6.

@damassi damassi force-pushed the add-babel-pipeline branch from 9871316 to fc5827e Compare August 14, 2017 21:04
artsyXapp.on('error', (error) => {
console.warn(error)
process.exit(1)
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@kanaabe
Copy link
Contributor

kanaabe commented Aug 14, 2017

👏 This is so awesome!

@kanaabe kanaabe merged commit 4ab5be0 into artsy:master Aug 14, 2017
@damassi damassi deleted the add-babel-pipeline branch August 14, 2017 21:18
@damassi
Copy link
Member Author

damassi commented Aug 14, 2017

😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants