-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Babel Pipeline, Better ESLint #1224
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damassi
force-pushed
the
add-babel-pipeline
branch
from
August 14, 2017 20:25
bc752dc
to
109983b
Compare
damassi
commented
Aug 14, 2017
env('./.env') | ||
} | ||
|
||
require('./boot') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created this boot loader so that from the point of ./boot onwards we can write ES6.
damassi
force-pushed
the
add-babel-pipeline
branch
from
August 14, 2017 20:27
109983b
to
9871316
Compare
damassi
force-pushed
the
add-babel-pipeline
branch
from
August 14, 2017 21:04
9871316
to
fc5827e
Compare
kanaabe
reviewed
Aug 14, 2017
artsyXapp.on('error', (error) => { | ||
console.warn(error) | ||
process.exit(1) | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
👏 This is so awesome! |
😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Babel to the flow, along with some common packages as taken from Force:
Notable items from above:
standard
andstandard-react
being the primary engines..svg
file imports are automatically converted into components that you can use like so:<Icon />
import baz from 'api/foo/bar/baz'
reaction
, but I want to setup server-side react rendering and this, similar to force, is needed to pluck those styles out