Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD] Upgrade relay #3621

Merged
merged 4 commits into from
Aug 14, 2020
Merged

[HOLD] Upgrade relay #3621

merged 4 commits into from
Aug 14, 2020

Conversation

damassi
Copy link
Member

@damassi damassi commented Aug 14, 2020

⚠️ HOLD

We need to coordinate npm publishing / release steps with the main upgrade PR here: artsy/force#5934

While finishing up artsy/force#5934 I noticed that force wouldn't boot and after some digging found that it led to the article routes causing an error around the artist tooltips. Then I remembered that we have just a single Relay component in our publishing code...

Going forward, until we completely retire reaction, we'll have to perform relay upgrades in parallel.

@damassi damassi requested a review from eessex August 14, 2020 00:48
@artsy-peril artsy-peril bot added the Version: Minor Indicates that this PR should have a minor deploy, usually for new features label Aug 14, 2020
@damassi damassi added the canary Deploy a canary for this PR label Aug 14, 2020
@damassi damassi added Version: Major Indicates that this PR should have a major deploy, usually for larger-breaking changes for clients and removed Version: Minor Indicates that this PR should have a minor deploy, usually for new features labels Aug 14, 2020
@zephraph
Copy link
Contributor

Thanks for helping push this forward @damassi! 🙏

@damassi damassi merged commit 6c3e439 into artsy:master Aug 14, 2020
@damassi damassi deleted the upgrade-relay branch August 14, 2020 18:55
@artsyit
Copy link
Contributor

artsyit commented Aug 14, 2020

🚀 PR was released in v28.0.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
canary Deploy a canary for this PR released Version: Major Indicates that this PR should have a major deploy, usually for larger-breaking changes for clients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants