Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plot_violin #14

Open
aloctavodia opened this issue Oct 5, 2023 · 3 comments
Open

Add plot_violin #14

aloctavodia opened this issue Oct 5, 2023 · 3 comments

Comments

@aloctavodia
Copy link
Contributor

No description provided.

@imperorrp
Copy link
Collaborator

The violin plot in its current implementation in #85 overlays the densities of multiple models when multiple models are provided on both 'left' and 'right' sides (although these sides can be toggled on/off with plot_kwargs). Do we want to keep this behavior or @OriolAbril's suggestion to have the first two models be mapped to the 'left' and 'right' sides of the violin plot, and then perhaps overlay the additional models beyond 2, or something else entirely?

@OriolAbril
Copy link
Member

My proposal is to raise an error if there are more than two models. I think overlaying things on a violin plot is a terrible idea and should never happen.

@imperorrp
Copy link
Collaborator

Okay, I'll add in a check and make the modifications to do so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants