Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ipywidgets layout for ppa #128

Closed
aloctavodia opened this issue Dec 10, 2022 · 6 comments · Fixed by #328
Closed

Improve ipywidgets layout for ppa #128

aloctavodia opened this issue Dec 10, 2022 · 6 comments · Fixed by #328

Comments

@aloctavodia
Copy link
Contributor

No description provided.

@rohanbabbar04
Copy link
Contributor

@aloctavodia I thought about this one...

We have many parameters in the pz.ppa that we should allow users to interact with. I have just tried the widgets (not the functionality) to include most of them.

Do let me know what you think about this, also feel free to suggest changes.

image

@aloctavodia
Copy link
Contributor Author

Not sure about this. Both the target and the boundaries should be defined before-hand, I don't see clearly why one would like to interact with them. Also if those values are changed the hole elicitation should start again, because previous values will become obsolete, so that's equivalent to just run ppa again.

For the "references" I see why a user may want to change it during elicitation.

@rohanbabbar04
Copy link
Contributor

rohanbabbar04 commented Feb 20, 2024

Ah I see...
What abt we remove the lower_bound, upper_bound and target along with no lower bound and no upper bound checkboxes.

And keep only draws and references for the user interaction

@aloctavodia
Copy link
Contributor Author

At this point draws is only used once, so it does not make sense to change it interactively. After #317 It will be used everytime we "resample", but even then, I'm not sure that this is something the user may want to interact with. Actually, in the future we may want to remove that option and use a fixed number that works well overall.

So, we should only add the "references" box

@rohanbabbar04
Copy link
Contributor

Noted...
We then keep the look of the interactive mode similar to the image

In the Horizontal box, we have our references(input parameters) followed by the radio buttons and then the carry-on/return prior button.
Is that fine?

@aloctavodia
Copy link
Contributor Author

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants