Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality code: Resolve all the issues showed by trunk check #34

Open
asacristani opened this issue Apr 4, 2024 · 2 comments
Open

Quality code: Resolve all the issues showed by trunk check #34

asacristani opened this issue Apr 4, 2024 · 2 comments
Labels
good first issue Good for newcomers improvement Something better done

Comments

@asacristani
Copy link
Owner

If you run trunk check -a, there are several issues to resolve.

@asacristani asacristani added good first issue Good for newcomers improvement Something better done labels Apr 4, 2024
@abdur-n-tr
Copy link

@asacristani I want to take on this issue but first I want to ask a couple of questions before proceeding so I can follow the standards that other contributors are following,

  • For PR submission, do we follow this,
    • Clone this repo, create a new branch, make our changes, push it to repo, and create PR to merge into master, if approved, will be merged into master.

Please guide me if we are following a different workflow here.

Also, I setup the project locally and ran trunk check -a and it highlighted a couple of issues in different categories as attached in the snapshot. Do you recommend fixing all of them in one go and submit PR or should I break them like one PR for "unformatted issues" and similarly for other issue types?

issue1

@asacristani
Copy link
Owner Author

@abdurrehman11 you are right.
Thanks so much for resolving this. I cannot wait for see your solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers improvement Something better done
Projects
Development

No branches or pull requests

2 participants