Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks are grouped together and addressing many rules at the same time #163

Closed
andreaskern74 opened this issue Sep 9, 2024 · 1 comment
Labels
isState:Accepted An issue that has been accepted by the group, which needs to be assigned to a responsible isType:Bug An issue that contains contradictions or errors in the standard.

Comments

@andreaskern74
Copy link
Collaborator

andreaskern74 commented Sep 9, 2024

Describe the bug

The current implementation for OpenDRIVE and OpenSCENARIO XML (__&OTX?_) addressing many rules at the same time. Example from semantic_xodr:

<Checker status="completed" checkerId="semantic_xodr" description="Evaluates elements in the file and their semantics to guarantee they are in conformity with the standard." summary="">
  <AddressedRule ruleUID="asam.net:xodr:1.7.0:road.lane.level_true_one_side"/>
  <AddressedRule ruleUID="asam.net:xodr:1.7.0:road.lane.access.no_mix_of_deny_or_allow"/>
  <AddressedRule ruleUID="asam.net:xodr:1.4.0:road.lane.link.lanes_across_lane_sections"/>
  <AddressedRule ruleUID="asam.net:xodr:1.4.0:road.linkage.is_junction_needed"/>
  <AddressedRule ruleUID="asam.net:xodr:1.7.0:road.lane.link.zero_width_at_start"/>
  <AddressedRule ruleUID="asam.net:xodr:1.7.0:road.lane.link.zero_width_at_end"/>
  <AddressedRule ruleUID="asam.net:xodr:1.4.0:road.lane.link.new_lane_appear"/>
  <AddressedRule ruleUID="asam.net:xodr:1.4.0:junctions.connection.connect_road_no_incoming_road"/>
  <AddressedRule ruleUID="asam.net:xodr:1.7.0:junctions.connection.one_connection_element"/>
  <AddressedRule ruleUID="asam.net:xodr:1.8.0:junctions.connection.one_link_to_incoming"/>
  <AddressedRule ruleUID="asam.net:xodr:1.7.0:junctions.connection.start_along_linkage"/>
  <AddressedRule ruleUID="asam.net:xodr:1.7.0:junctions.connection.end_opposite_linkage"/>
</Checker>

This conflicts with the defintion of a check: https://github.com/asam-ev/qc-framework/blob/3b96d855d836029d857a049dad94e46526e6e8bf/doc/manual/checker_library.md

image

To group checks together, there is the idea of having checker bundles. Note: It is ok that the checker libraries has only one checker bundle. But then this one should have many checks.

The biggest issue with the implementation is that without the feature #20, it is not possible to configure the criticality of different rule violations. At the moment, the user need to decide for all rules at the same time, if they should be reported and if the are info, warning or error.

Also the reporting is not clear, because the affected rule is not in focus at the moment.

Currently the structure of checks is aligned with the implementation subdirectories.

Expected behavior

Like the architecture describes: A check should addresses exactly one rule.

@andreaskern74 andreaskern74 added the isType:Bug An issue that contains contradictions or errors in the standard. label Sep 9, 2024
@andreaskern74 andreaskern74 added the isState:New A new issue that needs to be classified to a type. label Sep 9, 2024
@hoangtungdinh hoangtungdinh moved this to In progress in Quality Checker Sep 12, 2024
@andreaskern74 andreaskern74 added isState:Accepted An issue that has been accepted by the group, which needs to be assigned to a responsible and removed isState:New A new issue that needs to be classified to a type. labels Sep 12, 2024
@hoangtungdinh hoangtungdinh moved this from In progress to Can close in Quality Checker Sep 16, 2024
@AsamDiegoSanchez
Copy link
Member

According to IVEX the issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
isState:Accepted An issue that has been accepted by the group, which needs to be assigned to a responsible isType:Bug An issue that contains contradictions or errors in the standard.
Projects
Status: Done
Development

No branches or pull requests

2 participants