Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choice of tags breaks semantic versioning #491

Open
nyetwurk opened this issue Jul 8, 2023 · 2 comments
Open

Choice of tags breaks semantic versioning #491

nyetwurk opened this issue Jul 8, 2023 · 2 comments

Comments

@nyetwurk
Copy link

nyetwurk commented Jul 8, 2023

Bug Report

All tags are bad.

Summary

https://go.dev/ref/mod#versions

Major version suffixes

Starting with major version 2, module paths must have a major version suffix like /v2 that matches the major version. For example, if a module has the path example.com/mod at v1.0.0, it must have the path example.com/mod/v2 at version v2.0.0.

Current behavior

govalidator has all sorts of v10 and v11 tags.

How to reproduce

$ go get -u github.com/asaskevich/govalidator@v11.0.1
go: github.com/asaskevich/govalidator@v11.0.1: invalid version: module contains a go.mod file, so module path must match major version ("github.com/asaskevich/govalidator/v11")

Expected behavior

No output, but go.mod should have a github.com/asaskevich/govalidator/v11 in it.

@leild
Copy link

leild commented Jul 11, 2023

Okay, please give me a plan and version of the problem. Thank you.

@nyetwurk
Copy link
Author

Okay, please give me a plan and version of the problem. Thank you.

What are you asking for?

If you want to tag v11.x.x the full path of the module has to end in /v11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants