Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ambiguity in usage of maven properties docs #507

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Remove ambiguity in usage of maven properties docs #507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ For a detailed view of what has changed, refer to the {uri-repo}/commits/master[
Documentation::

* Migrate docs (README) to Antora site and publish them in gh-pages (#498)
* Remove ambiguity in usage of maven properties docs (#507)

== v2.1.0 (2020-09-15)

Expand Down Expand Up @@ -53,4 +54,4 @@ Build / Infrastructure::
* Updated jacoco-maven-plugin version from v0.8.2 to 0.8.5 (#479)
* Use maven-javadoc-plugin version defined in `pluginManagement` + update to v3.2.0 (#481)
* Add Maven Wrapper to project and CI builds (#484)
* Upgrade Asciidoctorj to 2.4.1 ad jRuby to 9.2.13.0 (#486)
* Upgrade Asciidoctorj to 2.4.1 ad jRuby to 9.2.13.0 (#486)
3 changes: 2 additions & 1 deletion docs/modules/plugin/partials/process-asciidoc-mojo-parameters.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,8 @@ Refer to the http://asciidoctor.org/docs/user-manual/#attribute-catalog[catalog
<source-highlighter>coderay</source-highlighter>
</attributes>
----
In addition to those attributes found in this section, any Maven property is also passed as attribute (replacing . by -).
In addition to attributes set in this section, Maven properties are also passed as attribute (replacing . by - in the name).
These include those defined in the `<properties>` section of the project, parent projects and the user's `settings.xml`.
+
[source,xml]
----
Expand Down
3 changes: 2 additions & 1 deletion docs/modules/site-integration/pages/index.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,8 @@ Specifies additional Ruby libraries not packaged in AsciidoctorJ, `empty` by def
attributes::
Similar to the plugin's `attributes`. +
Allows defining a set of Asciidoctor attributes to be passed to the conversion. +
In addition to those attributes found in this section, any Maven property is also passed as attribute (replacing . by -).
In addition to attributes set in this section, Maven properties are also passed as attribute (replacing . by - in the name).
These include those defined in the `<properties>` section of the project, parent projects and the user's `settings.xml`.
+
[source,xml]
----
Expand Down