Add ID to 'attributes' to be able to generate direct url from other docs #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsromero
force-pushed
the
docs/add-id-to-attributes
branch
from
c934b18
to
93a4481
Compare
abelsromero
force-pushed
the
docs/add-id-to-attributes
branch
from
93a4481
to
f2ecd6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a pull request and contributing to asciidoctor-maven-plugin!
What kind of change does this PR introduce? (check at least one)
What is the goal of this pull request?
Add an ID to the attributes description on the mojos so it can be directly referenced by URL.
More specifically, this is so we can do a redirect to sections that no longer exists and which content is found in the attributes description in https://asciidoctor.org/docs/. Similar to asciidoctor/asciidoctor.org#995.
Are there any alternative ways to implement this?
Not that I know of.
Are there any implications of this pull request? Anything a user must know?
Docs in docs.asciidoctor.org/ need to be rebuild.
Is it related to an existing issue?
Finally, please add a corresponding entry to CHANGELOG.adoc