Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(svelte): correct lazy loading #485

Merged
merged 6 commits into from
Feb 4, 2024
Merged

fix(svelte): correct lazy loading #485

merged 6 commits into from
Feb 4, 2024

Conversation

ascorbic
Copy link
Owner

@ascorbic ascorbic commented Feb 4, 2024

This is an attempt to fix #444, based on @adrienrn's example. This is mainly about ensuring the loading=lazy prop is applied after the src attribute.

Copy link

netlify bot commented Feb 4, 2024

Deploy Preview for unpic-qwik ready!

Name Link
🔨 Latest commit e4326f9
🔍 Latest deploy log https://app.netlify.com/sites/unpic-qwik/deploys/65bf4e0e7ccc460008b956b1
😎 Deploy Preview https://deploy-preview-485--unpic-qwik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance:
Accessibility:
Best Practices:
SEO:
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 4, 2024

Deploy Preview for unpic-vue ready!

Name Link
🔨 Latest commit e4326f9
🔍 Latest deploy log https://app.netlify.com/sites/unpic-vue/deploys/65bf4e0eb6df77000862ecd2
😎 Deploy Preview https://deploy-preview-485--unpic-vue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 4, 2024

Deploy Preview for unpic-solid ready!

Name Link
🔨 Latest commit e4326f9
🔍 Latest deploy log https://app.netlify.com/sites/unpic-solid/deploys/65bf4e0e6cb81c00083426cb
😎 Deploy Preview https://deploy-preview-485--unpic-solid.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 4, 2024

Deploy Preview for unpic-astro ready!

Name Link
🔨 Latest commit e4326f9
🔍 Latest deploy log https://app.netlify.com/sites/unpic-astro/deploys/65bf4e0efbad17000899dc2f
😎 Deploy Preview https://deploy-preview-485--unpic-astro.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 4, 2024

Deploy Preview for unpic-webc ready!

Name Link
🔨 Latest commit e4326f9
🔍 Latest deploy log https://app.netlify.com/sites/unpic-webc/deploys/65bf4e0e140e9c00087daff7
😎 Deploy Preview https://deploy-preview-485--unpic-webc.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 4, 2024

Deploy Preview for unpic-svelte ready!

Name Link
🔨 Latest commit e4326f9
🔍 Latest deploy log https://app.netlify.com/sites/unpic-svelte/deploys/65bf4e0ed1adf500087e60f7
😎 Deploy Preview https://deploy-preview-485--unpic-svelte.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance:
Accessibility:
Best Practices:
SEO:
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 4, 2024

Deploy Preview for unpic-next ready!

Name Link
🔨 Latest commit e4326f9
🔍 Latest deploy log https://app.netlify.com/sites/unpic-next/deploys/65bf4e0e92e78400070cea4b
😎 Deploy Preview https://deploy-preview-485--unpic-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 4, 2024

Deploy Preview for unpic-preact canceled.

Name Link
🔨 Latest commit e4326f9
🔍 Latest deploy log https://app.netlify.com/sites/unpic-preact/deploys/65bf4e0ed49bde00080d488c

Copy link

netlify bot commented Feb 4, 2024

Deploy Preview for unpic-docs ready!

Name Link
🔨 Latest commit e4326f9
🔍 Latest deploy log https://app.netlify.com/sites/unpic-docs/deploys/65bf4e0ed49bde00080d488e
😎 Deploy Preview https://deploy-preview-485.preview.unpic.pics
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 4, 2024

Deploy Preview for unpic-lit ready!

Name Link
🔨 Latest commit e4326f9
🔍 Latest deploy log https://app.netlify.com/sites/unpic-lit/deploys/65bf4e0e3c853900087bd1f6
😎 Deploy Preview https://deploy-preview-485--unpic-lit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 4, 2024

Deploy Preview for unpic-angular ready!

Name Link
🔨 Latest commit e4326f9
🔍 Latest deploy log https://app.netlify.com/sites/unpic-angular/deploys/65bf4e0e31afa90008b3e7ae
😎 Deploy Preview https://deploy-preview-485--unpic-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodiakhq kodiakhq bot merged commit c44fad7 into main Feb 4, 2024
48 checks passed
@kodiakhq kodiakhq bot deleted the svelte-loading branch February 4, 2024 09:20
@mixie-bot mixie-bot bot mentioned this pull request Feb 4, 2024
kodiakhq bot pushed a commit that referenced this pull request Feb 4, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>svelte: 0.0.47</summary>

## [0.0.47](svelte-v0.0.46...svelte-v0.0.47) (2024-02-04)


### Bug Fixes

* **svelte:** correct lazy loading ([#485](#485)) ([c44fad7](c44fad7))
</details>

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@unpic/svelte: lazy loading problem (different behavior than @unpic/react)
1 participant