fix(react): handle fetchpriority vs fetchPriority #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for unpic-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for unpic-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for unpic-angular ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ascorbic
changed the title
Merged
kodiakhq bot
pushed a commit
that referenced
this pull request
Apr 28, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>react: 0.1.14</summary> ## [0.1.14](react-v0.1.13...react-v0.1.14) (2024-04-28) ### Bug Fixes * **react:** handle fetchpriority vs fetchPriority ([#644](#644)) ([6b76808](6b76808)) * **react:** support Next.js server component ([#646](#646)) ([a2e58ea](a2e58ea)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When facebook/react#25927 was merged it meant that React would accept
fetchPriorityas a prop. Unfortunately it then wouldn't acceptfetchpriorityanymore. This would lead to scary error messages in dev or SSR. In Next.js there's no way to know which version you're using, because Next.js reports both versions as 18.x, even when actually using the bundled experimental version that includes this change. The upshot is that in Next.js, pages router needsfetchpriorityand app router needsfetchPriority. The best way to detect which one you're using is to look for the existence ofuse(). React I love you but you're bringing me down.Fixes #425