[sql lab] fix alt-enter runs out-of-date SQL (apache#2603)

ascott · Apr 13, 2017 · 6c68a21 · 6c68a21
1 parent db02b33
commit 6c68a21
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/superset/assets/javascripts/SqlLab/components/AceEditorWrapper.jsx b/superset/assets/javascripts/SqlLab/components/AceEditorWrapper.jsx
@@ -62,12 +62,16 @@ class AceEditorWrapper extends React.PureComponent {
   onBlur() {
     this.props.onBlur(this.state.sql);
   }
+  onAltEnter() {
+    this.props.onBlur(this.state.sql);
+    this.props.onAltEnter();
+  }
   onEditorLoad(editor) {
     editor.commands.addCommand({
       name: 'runQuery',
       bindKey: { win: 'Alt-enter', mac: 'Alt-enter' },
       exec: () => {
-        this.props.onAltEnter();
+        this.onAltEnter();
       },
     });
     editor.$blockScrolling = Infinity; // eslint-disable-line no-param-reassign
@@ -76,6 +80,9 @@ class AceEditorWrapper extends React.PureComponent {
         this.props.queryEditor, editor.getSelectedText());
     });
   }
+  getCompletions(aceEditor, session, pos, prefix, callback) {
+    callback(null, this.state.words);
+  }
   setAutoCompleter(props) {
     // Loading table and column names as auto-completable words
     let words = [];
@@ -101,9 +108,6 @@ class AceEditorWrapper extends React.PureComponent {
       }
     });
   }
-  getCompletions(aceEditor, session, pos, prefix, callback) {
-    callback(null, this.state.words);
-  }
   textChange(text) {
     this.setState({ sql: text });
   }