Support for ASDF Standard requirements on extensions #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslavich
requested review from
jdavies-st,
kmacdonald-stsci and
perrygreenfield
eslavich
force-pushed
the
eslavich-implement-asdf-standard-requirement
branch
3 times, most recently
from
3f54695
to
e545be2
Compare
eslavich
force-pushed
the
eslavich-implement-asdf-standard-requirement
branch
from
e545be2
to
e5039c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is branched off of #850. It adds support for specifying an ASDF Standard version requirement as an attribute on the extension class. We'll need this for the older transform extensions, each of which corresponds to a specific ASDF Standard version. It'll also be handy when we implement the core extension (currently
asdf.extension.BuiltinExtension) using the new API.