Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to new extension code #874

Merged

Conversation

eslavich
Copy link
Contributor

@eslavich eslavich commented Sep 4, 2020

Some fixes for issues that were uncovered while testing converters in asdf-astropy:

  • Sort plugins by package name + plugins from the asdf package at the end so that extension packages can override built-in plugins.
  • Change AsdfFile.extensions property to return "user extensions" only, that is to say, extensions that were passed in to AsdfFile.__init__ or asdf.open.
  • Update docstrings to note where ExtensionProxy is returned.
  • Remove some features that allowed referring to extensions by URI. I think I went a little overboard with implementing those before we had a real use case, they can always be revived later.
  • Include the extension URI in the ExtensionProxy repr to aid in debugging.

Copy link
Contributor

@jdavies-st jdavies-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

asdf/extension/_extension.py Outdated Show resolved Hide resolved
asdf/fits_embed.py Show resolved Hide resolved
@eslavich eslavich force-pushed the eslavich-fixes-due-to-asdf-astropy branch from 55ec1a3 to 623cd9f Compare September 11, 2020 14:24
@eslavich eslavich merged commit 7fe34a2 into asdf-format:master Sep 24, 2020
@eslavich eslavich deleted the eslavich-fixes-due-to-asdf-astropy branch September 24, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants