Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adds "grep -P" to the list of banned commands #1064

Merged
merged 3 commits into from
Oct 6, 2021
Merged

fix: Adds "grep -P" to the list of banned commands #1064

merged 3 commits into from
Oct 6, 2021

Conversation

threkk
Copy link
Contributor

@threkk threkk commented Oct 6, 2021

Summary

As explained in #1062 #1033, -P is an option that does not exist in
OSX and causes problems of compatibility.

Fixes: #1062

@threkk threkk requested a review from a team as a code owner October 6, 2021 21:25
@threkk threkk changed the title tests: Adds "grep -P" to the list of banned commands fix: Adds "grep -P" to the list of banned commands Oct 6, 2021
@threkk
fix: Adds "grep -P" to the list of banned commands
56bdbe9 
As explained in asdf-vm#1062 asdf-vm#1033, `-P` is an option that does not exist in
OSX and causes problems of compatibility.
jthegedus
jthegedus approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @threkk

@jthegedus jthegedus merged commit 8a515f4 into asdf-vm:master Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jthegedus jthegedus jthegedus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: ban grep -P as it is *nix specific
2 participants
@threkk @jthegedus