Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clarify the wording when no version is set #1088

Merged
merged 2 commits into from
Nov 14, 2021
Merged

fix: clarify the wording when no version is set #1088

merged 2 commits into from
Nov 14, 2021

Conversation

offbyone
Copy link
Contributor

@offbyone offbyone commented Nov 8, 2021

Summary

"no version set" can read as a noun, this confused someone I work with
recently :)

Other Information

@offbyone
fix: clarify the wording when no version is set
78651a2 
"no version set" can read as a noun, this confused someone I work with
recently :)
@offbyone offbyone requested a review from a team as a code owner November 8, 2021 19:56
jthegedus
jthegedus approved these changes Nov 14, 2021
View reviewed changes
Copy link
Contributor

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jthegedus
Copy link
Contributor

shfmt made some changes for some reason, I was using the shfmt version in the repo's .tool-versions.

@jthegedus jthegedus merged commit 4116284 into asdf-vm:master Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jthegedus jthegedus jthegedus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@offbyone @jthegedus