Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(completions): bash improvements #1329

Merged
merged 4 commits into from
Oct 18, 2022
Merged

feat(completions): bash improvements #1329

merged 4 commits into from
Oct 18, 2022

Conversation

scop
Copy link
Contributor

@scop scop commented Sep 7, 2022

Summary

Various bash completion improvements.

Other Information

See individual commits for details.

@scop scop requested a review from a team as a code owner September 7, 2022 04:52
@jthegedus
Copy link
Contributor

@scop please run scripts/shfmt.bash

@scop
Copy link
Contributor Author

scop commented Sep 9, 2022

Done.

Stratus3D
Stratus3D approved these changes Sep 9, 2022
View reviewed changes
Copy link
Member

@Stratus3D Stratus3D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had a chance to test these changes but they look good to me.

@Stratus3D Stratus3D merged commit 7c802c3 into asdf-vm:master Oct 18, 2022
@github-actions github-actions bot mentioned this pull request Oct 18, 2022
Merged
@scop scop deleted the feat/completion-improvements branch October 19, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stratus3D Stratus3D Stratus3D approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scop @jthegedus @Stratus3D