Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: version filter expressions not passed to latest command on use with local/global #1410

Open
jthegedus opened this issue Dec 30, 2022 · 0 comments
Labels

Comments

@jthegedus
Copy link
Contributor

jthegedus commented Dec 30, 2022

Describe the Bug

asdf local nodejs latest works. At the time of writing, .tool-versions will have nodejs 19.3.0 added to it correctly.

asdf local nodejs latest 16 does not work. The filter of 16 is never passed to the latest command.

Steps to Reproduce

  1. asdf local nodejs latest
  2. cat .tool-versionsand seenodejs 19.3.0`
  3. asdf local nodejs latest 16
  4. see error version 16 is not installed for nodejs

Expected Behaviour

asdf local nodejs latest 16 should run resolve the latest version for the filtered name, as happens with asdf latest nodejs 16, and have the result stored in .tool-versions.

Actual Behaviour

Errors as the code path for latest 16 is not resolved.

The codepath

version=$(latest_command "$plugin_name" "${version_info[1]}")
should be executed

Environment

OS:
Linux art-win11 5.15.79.1-microsoft-standard-WSL2 #1 SMP Wed Nov 23 01:01:46 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

SHELL:
fish, version 3.3.1

ASDF VERSION:
v0.11.0-7460809

ASDF ENVIRONMENT VARIABLES:
ASDF_DIR=/home/jthegedus/.asdf

ASDF INSTALLED PLUGINS:
bats                         https://github.com/timgluz/asdf-bats.git main 299551f
deno                         https://github.com/asdf-community/asdf-deno.git master 87442fe
firebase                     https://github.com/jthegedus/asdf-firebase.git main 4a0ac90
gcloud                       https://github.com/jthegedus/asdf-gcloud main a71ab95
java                         https://github.com/halcyon/asdf-java.git master 0720a4b
nodejs                       https://github.com/asdf-vm/asdf-nodejs.git master c9e5df4
pnpm                         https://github.com/jonathanmorley/asdf-pnpm.git master 95752a9
python                       https://github.com/danhper/asdf-python.git master 8505457
shellcheck                   https://github.com/luizm/asdf-shellcheck.git master 0f79f0b
shfmt                        https://github.com/luizm/asdf-shfmt.git master a42c5ff
v                            https://github.com/jthegedus/asdf-v main 99136a7

asdf plugins affected (if relevant)

Any

Other

Discovered in #1342 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant