fix: Nushell plugin list --urls #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure what we can do about external test fixtures for plugins from actual remotes 🤷 |
|
@jthegedus Well, one solution would be to create some test repositories and actually clone them. Shall I open a new issue? |
|
An issue to discuss a solution would be best, yes. I would like to explore other alternatives if possible though, as maintaining a whole set of repos for testing is a bit annoying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #1503.
Other Information
Also adds tests for the
--refsflag and its combination with--urls.Note that installed plugins can have a "remote" URL of two forms:
http[s]|gitand terminating with.git)N.B.: At the moment this PR is only testing for plugins added from a local folder (second case above). To test plugins that have been cloned from an actually remote repository (first case above) there have to be testing fixtures that clone them first.