fix: rename internal plugin repository functions #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use
pluginin the function name for functions that reference the plugin repository.I was making these changes in #1437 and thought they could be pulled out separately for easier review.
Other Information
I am torn about the impact on semver here (
fixorchore). On the one hand, code is being changed that users would execute, so this code should be released under a new version, afix. Whereas the external API is not being changed so it could probably be achorewith the change going out with the next release (any subsequentfixorfeat). 🤷Historically I have been encouraging any change to code that effects the user to go under
fix, even if just code style changes, so will stick to that here. But this is certainly open to discussion should anyone care.