Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve readability of the non-set nullglob guard #1545

Merged
merged 1 commit into from
Apr 17, 2023
Merged

fix: improve readability of the non-set nullglob guard #1545

merged 1 commit into from
Apr 17, 2023

Conversation

hyperupcall
Copy link
Contributor

Split from #1544

@hyperupcall hyperupcall requested a review from a team as a code owner April 17, 2023 03:29
@jthegedus
Copy link
Contributor

Addresses feedback in #1485 (comment)

@jthegedus jthegedus changed the title fix: Improve readability of the non-set nullglob guard fix: improve readability of the non-set nullglob guard Apr 17, 2023
jthegedus
jthegedus approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jthegedus jthegedus merged commit f273612 into asdf-vm:master Apr 17, 2023
@github-actions github-actions bot mentioned this pull request Apr 17, 2023
Merged
@hyperupcall hyperupcall deleted the globstuff branch April 17, 2023 07:23
@Stratus3D
Copy link
Member

Thanks @hyperupcall !

@chenrui333 chenrui333 mentioned this pull request Jun 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jthegedus jthegedus jthegedus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hyperupcall @jthegedus @Stratus3D