Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve lint and test scripts #1607

Merged
merged 1 commit into from
Sep 10, 2023
Merged

fix: improve lint and test scripts #1607

merged 1 commit into from
Sep 10, 2023

Conversation

hyperupcall
Copy link
Contributor

Summary

  • Makes prints semantically dry
  • Use physical directory when comparing to see if script is running in asdf repository. (Unfortunately set -o physical does not work with $PWD)
  • Other small fixes

@hyperupcall hyperupcall requested a review from a team as a code owner July 29, 2023 00:58
@hyperupcall hyperupcall changed the title fix: Lint and test script fixes and improvements fix: Improvements for lint and test scripts Jul 29, 2023
jthegedus
jthegedus approved these changes Sep 10, 2023
View reviewed changes
Copy link
Contributor

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Sorry for the delay

@jthegedus jthegedus changed the title fix: Improvements for lint and test scripts fix: improve lint and test scripts Sep 10, 2023
@jthegedus jthegedus merged commit b320803 into asdf-vm:master Sep 10, 2023
1 check passed
@github-actions github-actions bot mentioned this pull request Sep 10, 2023
Merged
@hyperupcall hyperupcall deleted the hyperupcall-scripts-fixes branch September 10, 2023 20:47
@p-linnane p-linnane mentioned this pull request Sep 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jthegedus jthegedus jthegedus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyperupcall @jthegedus