-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow plugin callbacks to be in any language #995
Conversation
Looking good. Would it be worth adding |
We're still using bash in one place, and of course we use it in the shebang line because asdf written in Bash, so I don't think we are quite ready for that yet. But possibly soon, assuming we can ignore the shebang lines. |
acfda3f
to
48c0ecb
Compare
The original code invoked all plugin callback scripts with Bash. While all plugin callback scripts are currently implemented in Bash it is conceivable that another a better shell language will emerge and become popular. I dont think mandating Bash is the right choice anymore. I do think that for nearly all plugins Bash is the right choice right now and for compatibility purposes Bash should be encouraged.
48c0ecb
to
c9aca49
Compare
@jthegedus I think this PR is ready to be merged. Should I merge it now or wait until the next release? |
I'd just merge it now. I'd consider all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jthegedus I overlooked the WIP label. I meant to remove it. The only thing I didn't address here was unit tests, but being that I only removed code in this PR, I figured it wasn't critical. I do want to write basic unit tests for this however. I will do so in a later PR. |
The original code invoked all plugin callback scripts with Bash.
While all plugin callback scripts are currently implemented in
Bash it is conceivable that another a better shell language will
emerge and become popular. I dont think mandating Bash is the
right choice anymore. I do think that for nearly all plugins
Bash is the right choice right now and for compatibility
purposes Bash should be encouraged.