Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: excludes "milestone" releases in "latest" command #1307

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

log2
Copy link
Contributor

@log2 log2 commented Jul 19, 2022

Summary

Fixes: #1306

Other Information

@log2 log2 requested a review from a team as a code owner July 19, 2022 08:51
@log2 log2 changed the title Excluded "milestone" releases in "latest" command fixes: excludes "milestone" releases in "latest" command Jul 19, 2022
@log2 log2 changed the title fixes: excludes "milestone" releases in "latest" command fix: excludes "milestone" releases in "latest" command Jul 19, 2022
@jthegedus
Copy link
Contributor

jthegedus commented Jul 20, 2022

This is a minor change that I don't think it will hurt anyone, however we want to encourage plugin authors to implement their own bin/latest-stable script which you can see is called 9 lines above this change. Docs: https://asdf-vm.com/plugins/create.html#bin-latest-stable

If @Stratus3D has no objections then happy to merge

@log2
Copy link
Contributor Author

log2 commented Jul 20, 2022

Thank you for the suggestion @jthegedus , in fact I already implemented latest-stable in other asdf plugins (such as kubectl's asdf plugin, see here, where a direct endpoint to get latest stable version is provided by kubectl's maintainers), so I can definitely contribute back to asdf gradle plugin, too, using similar techniques, plus filtering out of "milestone" releases. I will try that way (PR to asdf gradle) as well.

@log2
Copy link
Contributor Author

log2 commented Jul 22, 2022

I've added PR to asdf-gradle project, as promised, @jthegedus

Copy link
Member

@Stratus3D Stratus3D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the changes here but the existence of this code bothers me the in the same way as the PR I was reviewing earlier - #1191 (comment)

@Stratus3D
Copy link
Member

Thanks for the PR @log2 ! Sorry for the late review.

@Stratus3D Stratus3D merged commit 5334d1d into asdf-vm:master Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: "milestone" releases are not excluded when searching for "latest" version
3 participants