Skip to content
This repository has been archived by the owner on May 21, 2020. It is now read-only.

Add build against scala 2.13 #17

Open
julianhowarth opened this issue Jan 9, 2020 · 6 comments
Open

Add build against scala 2.13 #17

julianhowarth opened this issue Jan 9, 2020 · 6 comments

Comments

@julianhowarth
Copy link
Contributor

Is it possible to start publishing artifacts against scala 2.13?

@julianhowarth
Copy link
Contributor Author

I have adjusted the sbt build locally and can build against 2.13 but I had to:

  • exclude akka 2.4 (not available for 2.13)
  • remove -Yno-adapted-args (no longer valid afaict)
  • remove -Xfuture (no longer valid)
  • upgrade scalatest to 3.1.0
  • add "org.scalatestplus" %% "mockito-1-10" % "3.1.0.0" % Test as scalatest has split out separate modules
  • in DefaultTestContext.scala, replace import org.scalatest.mockito.MockitoSugar with import org.scalatestplus.mockito.MockitoSugar
  • in KinesisWorkerSourceSourceSpec, fix a test failure due to change in error message

@aserrallerios
Copy link
Owner

Hi @julianhowarth, feel free to open a PR with those changes if you think it's worth it.

Hopefully, soon this will be available in alpakka, but we can still release "maintenance" versions.

@aserrallerios
Copy link
Owner

The PR has been merged, so expect it soon on alpakka :)

@joelvim
Copy link

joelvim commented Feb 4, 2020

Hello, I am also interested by Scala 2.13 support and also Akka 2.6 support. I don't see the PR you are talking about. I don't understand, this project is now integrated into alpakka?

@aserrallerios
Copy link
Owner

Hi @joelvim.

Yes, this project is deprecated in favor of the alpakka KCL components. The PR is this one:

akka/alpakka#1667

The code has been integrated but not a new alpakka release has been made, so we'll need to wait for Alpakka 2.0.0-M3 or RC/official releases.

I'll try to find some time to document properly the README on this repository and archive it when the alpakka release is made.

@joelvim
Copy link

joelvim commented Feb 4, 2020

This is great! Thank you very much for this work!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants