Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use check logic from azm #67

Merged
merged 28 commits into from
Feb 19, 2024
Merged

Use check logic from azm #67

merged 28 commits into from
Feb 19, 2024

Conversation

ronenh
Copy link
Contributor

@ronenh ronenh commented Dec 14, 2023

Copy link

github-actions bot commented Dec 14, 2023

Pull Request Test Coverage Report for Build 7674697723

  • -195 of 334 (41.62%) changed or added relevant lines in 16 files are covered.
  • 72 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+3.6%) to 31.654%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/bdb/migrate/mig/mig.go 0 1 0.0%
pkg/ds/graph.go 0 1 0.0%
pkg/directory/v3/model.go 5 7 71.43%
pkg/ds/relation.go 9 11 81.82%
pkg/directory/v3/exporter.go 0 4 0.0%
pkg/ds/check.go 0 9 0.0%
pkg/ds/check_relation.go 0 10 0.0%
pkg/directory/v3/writer.go 26 37 70.27%
pkg/ds/check_permission.go 0 12 0.0%
pkg/directory/v2/importer.go 2 18 11.11%
Files with Coverage Reduction New Missed Lines %
pkg/ds/check.go 1 0.0%
pkg/ds/relation.go 1 65.61%
pkg/bdb/model.go 2 55.56%
pkg/directory/v2/importer.go 2 9.47%
pkg/ds/check_relation.go 3 0.0%
pkg/ds/validate.go 3 72.73%
pkg/ds/check_permission.go 4 0.0%
pkg/bdb/generic.go 5 55.26%
pkg/bdb/migrate/mig/mig.go 8 30.19%
pkg/bdb/migrate/mig003/migrate.go 43 3.17%
Totals Coverage Status
Change from base Build 7626348395: 3.6%
Covered Lines: 1137
Relevant Lines: 3592

💛 - Coveralls

@ronenh ronenh merged commit 800034b into main Feb 19, 2024
2 checks passed
@ronenh ronenh deleted the azm-check branch February 19, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants