Merge pull request #518 from Fisiu/allow_empty_tags

Set tags only if passed any.
AsgardCms · Apr 20, 2018 · 4c30c45 · 4c30c45
2 parents 22ccee9 + 52d278a
commit 4c30c45
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/Modules/Tag/Tests/Integration/TaggableTraitTest.php b/Modules/Tag/Tests/Integration/TaggableTraitTest.php
@@ -153,6 +153,17 @@ public function it_gets_pages_with_non_latin_tags()
         $this->assertCount(1, Page::whereTag(['한글-태그'])->get());
     }
 
+    /** @test */
+    public function it_creates_page_without_tags()
+    {
+        $this->createPage(['original tag']);
+
+        $page = $this->page->find(1);
+        $page->setTags(null);
+
+        $this->assertEmpty(Page::first()->tags->count());
+    }
+
     private function createPage(array $tags = [])
     {
         return $this->page->create([

diff --git a/Modules/Tag/Traits/TaggableTrait.php b/Modules/Tag/Traits/TaggableTrait.php
@@ -97,6 +97,10 @@ public static function allTags()
      */
     public function setTags($tags, $type = 'slug')
     {
+        if (empty($tags)) {
+            $tags = [];
+        }
+
         // Get the current entity tags
         $entityTags = $this->tags->pluck($type)->all();