Abstract csv download inside Response macro

AsgardCms · Aug 3, 2017 · b5b5917 · b5b5917
1 parent dec0d48
commit b5b5917
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/Modules/Core/macros.php b/Modules/Core/macros.php
@@ -345,3 +345,11 @@
 
     return new HtmlString($string);
 });
+
+Response::macro('csv', function ($file, $filename, $status = 200, $headers = []) {
+    return response($file, $status, array_merge([
+        'Content-Type' => 'application/csv',
+        'Content-Disposition' => "attachment; filename={$filename}",
+        'Pragma' => 'no-cache',
+    ], $headers));
+});
diff --git a/Modules/Translation/Http/Controllers/Admin/TranslationController.php b/Modules/Translation/Http/Controllers/Admin/TranslationController.php
@@ -53,11 +53,7 @@ public function update(TranslationTranslation $translationTranslation, Request $
 
     public function export(TranslationsExporter $exporter)
     {
-        return response()->make($exporter->export(), 200, [
-            'Content-Type' => 'application/csv',
-            'Content-Disposition' => "attachment; filename={$exporter->getFileName()}",
-            'Pragma' => 'no-cache',
-        ]);
+        return response()->csv($exporter->export(), $exporter->getFileName());
     }
 
     public function import(ImportTranslationsRequest $request, TranslationsImporter $importer)