You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In my case i have a couple of custom_rules defined in the root project's .swiftlint.yml, but i need to disable some of them in one of the subdirectories root/foo/bar/.swiftlint.yml. This worked great with SwiftLint v0.39.0, but with the changes I mentioned it doesn't work anymore. Opting out of passing a --config would fix my issue.
I think we could achieve that by updating this validation:
Yeah, this sounds like a great idea! It seems like removing the config_file_path if it's unspecified would work better with how SwiftLint is operating. ie: it is SwiftLint's job to find the config file if it's not specified (not ours).
Given the breaking changes to
--config
in the latest versions of SwiftLint, I was wondering if we could opt out of passing a config file.In my case i have a couple of custom_rules defined in the root project's
.swiftlint.yml
, but i need to disable some of them in one of the subdirectoriesroot/foo/bar/.swiftlint.yml
. This worked great with SwiftLint v0.39.0, but with the changes I mentioned it doesn't work anymore. Opting out of passing a--config
would fix my issue.I think we could achieve that by updating this validation:
danger-ruby-swiftlint/lib/danger_plugin.rb
Lines 70 to 74 in 92cf9a9
Lmk what you guys think. I wouldn't mind helping with a PR.
The text was updated successfully, but these errors were encountered: