Generate path to mscorlib #189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks -- I haven't checked PRs and issues in MirrorSharp for a while, but I'll take a look now. |
ashmind
reviewed
Dec 15, 2022
| @""{TargetFrameworkRootPath}.NETFramework\{TargetFrameworkVersion}\mscorlib.dll""; | ||
| #endif | ||
| }} | ||
| "; |
There was a problem hiding this comment.
Interesting! I am reluctant to use a whole custom task for this -- if this needs to be written dynamically, would it be simpler to use a built-in WriteLinesToFile?
However, the other question is if it needs to be written during build -- is there no way to discover it at runtime? I think .NET Framework is generally easier to discover than modern .NET, without same runtime/SDK distinction.
# Conflicts: # .github/workflows/dotnet.yml
# Conflicts: # MirrorSharp.sln.DotSettings
|
@ashmind just ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #188