Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Hover Animation issue for What's New Button #4

Open
ashutosh1919 opened this issue Jan 13, 2021 · 2 comments
Open

The Hover Animation issue for What's New Button #4

ashutosh1919 opened this issue Jan 13, 2021 · 2 comments
Labels
good first issue Good for newcomers

Comments

@ashutosh1919
Copy link
Owner

As observed as part of #2 , The hover animation of button is getting interfered by the component which is below the current component.

@ashutosh1919 ashutosh1919 added the good first issue Good for newcomers label Jan 18, 2021
@extory3
Copy link

extory3 commented Feb 12, 2021

I took my review on it. The hover effect causes to repeat the animation twice for text and background color transitions:

  1. when mouse enters (animation starts and ends);
  2. and when mouse leaves (animation starts and end again, but at last);

Do you think it's valid to add inline css style or javascript/react way (mouseenter & mouseleave)?
I will try fix it soon.

@ashutosh1919
Copy link
Owner Author

@extory3 , I have similar take on this. But I am not sure whether that is the exact problem. Feel free to explore and raise PR. Looking forward for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants