Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sources being dropped when no name given by user #219

Closed
ajstewart opened this issue Oct 12, 2020 · 0 comments · Fixed by #220
Closed

Sources being dropped when no name given by user #219

ajstewart opened this issue Oct 12, 2020 · 0 comments · Fixed by #220
Assignees
@ajstewart
Labels
bug Something isn't working

Comments

@ajstewart
Copy link
Collaborator

If the user doesn't define a source_name then they are being left as empty which in the query_df are NaN. These are then dropped by a dropna() later on.

This seems like a regression from version 1 as names used to be automatically generated if they weren't given.

Reported by @tkteo.
@ajstewart ajstewart added the bug Something isn't working label Oct 12, 2020
@ajstewart ajstewart self-assigned this Oct 12, 2020
@ajstewart ajstewart mentioned this issue Oct 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajstewart ajstewart

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 219 fix source names askap-vast/vast-tools
1 participant
@ajstewart