Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to react 19 #48

Closed
jraut opened this issue Nov 4, 2024 · 5 comments
Closed

Update to react 19 #48

jraut opened this issue Nov 4, 2024 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@jraut
Copy link

jraut commented Nov 4, 2024

Hello,

I just updated to react 19 which is right behind the corner. Ran into a problem:

TypeError: Cannot read properties of undefined (reading 'ReactCurrentDispatcher') at <unknown> (path/node_modules/fabricjs-react/dist/fabricjs-react.es.js:318:15) at Or (path/node_modules/fabricjs-react/dist/fabricjs-react.es.js:759:4) at <unknown> (path/node_modules/fabricjs-react/dist/fabricjs-react.es.js:762:74) at <unknown> (path/node_modules/fabricjs-react/dist/fabricjs-react.es.js:763:3)

@armedi
Copy link
Contributor

armedi commented Dec 6, 2024

I got similar issue today after upgrading to react 19

@armedi
Copy link
Contributor

armedi commented Dec 7, 2024

I got it working with this build config changes https://github.com/asotog/fabricjs-react/compare/master...armedi:fabricjs-react:master?expand=1

You can try it with

npm i https://github.com/armedi/fabricjs-react/releases/download/v2.0.1/fabricjs-react-2.0.1.tgz

@armedi armedi mentioned this issue Dec 7, 2024
@armedi
Copy link
Contributor

armedi commented Dec 10, 2024

Hi @jraut, does this solve your problem?

@jraut
Copy link
Author

jraut commented Dec 15, 2024

This looks really good, thanks @armedi for taking it forward. I have not been able to try it out in a comprehensive manner yet. I wish I could, but updating to React 19 is coming "soon" and therefore I could not prioritise this more so far.

@asotog
Copy link
Owner

asotog commented Dec 16, 2024

looks good thanks guys, new version published https://codesandbox.io/p/sandbox/flamboyant-wind-ff3x8

@asotog asotog closed this as completed Dec 16, 2024
@asotog asotog added enhancement New feature or request help wanted Extra attention is needed labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants