Feature Request: Exclude lines from conversion with a comment

[CarliJoy]

It would be nice if line/block could be excluded from upgrading with a comment like # nopyupgrade or # start nopyupgrade in order to keep specific lines:
i.e. dict(foo="bar") when intended.

We are discussion to include pyupgrade in our teams pipeline but some team mate made this an requirement.

Would / Will this be possible in the future?

Have a glimps look in the source I don't see how to introduce this easily :-/

Any thoughts?

[asottile]

no sorry, pyupgrade is an opinionated tool if you don't like the opinions don't use it

the whole point is that there's no discussions

[asottile]

also dict(foo="bar") does not get rewritten and it's slower than a literal

[CarliJoy]

Understood. Thanks for the fast feedback :)

[JacobHayes]

I greatly appreciate the opinionated nature, but wonder if there might still be a valid use for this. For example, I'm working with code that explicitly inspects (user defined) type hints. In tests I confirm tuple[int] and Tuple[int] are both handled properly. I'd like for the rest of my code to use new hint syntax, but spot-disable in tests. Otherwise, running pyupgrade --keep-runtime-typing --py39-plus changed both to tuple[int], triggering a test failure + reduced coverage. Tuple = getattr(typing, "Tuple") works as a questionable workaround (without having to ignore tests/ completely). 😅

This seems a bit different than say black as there may be runtime observable differences that may need an escape hatch. However - if you still prefer this not be added, I can understand that too!

[asottile]

you're looking for --keep-runtime-typing