-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work with RBE and --experimental_allow_unresolved_symlinks enabled once Bazel supports it #308
Comments
With the 5.3.0 release candidate is this fixed? @gregmagolan |
It will not. It looks like 6.0 is where they will land. Relevant issue to follow the progress is this one bazelbuild/bazel#10298. |
With bazelbuild/bazel#15781 landed today, we think |
#400 shows that rules_js is now working with RBE at HEAD! However it requires one change to Bazel which is on this fork: https://github.com/aspect-build/bazel/releases/tag/6.0.0-aspect1 https://github.com/aspect-build/rules_js/blob/main/.github/workflows/ci.yaml#L56 shows where we select our fork for RBE builds on CI. |
For anyone who wants to try RBE with rules_js or rules_ts now, here are the steps:
|
bazelbuild/bazel#16272 is the PR we expect will fully resolve this, and should make it into Bazel 6.0 :) |
bazelbuild/bazel#16272 is landed on master bazelbuild/bazel@d834905 |
Latest rules_js works with Bazel 6.0.0rc2 with RBE. Closing this issue. |
With #283 landed, rules_js will now use the ctx.actions.declare_symlink API to create all of the symlinks in the symlinks node_modules tree if the
--experimental_allow_unresolved_symlinks
flag is set.This feature is not yet stable in Bazel (see bazelbuild/bazel#10298) and is currently being stabilized by @fmeum split across multiple PRs to bazel such as bazelbuild/bazel#15963.
This can slip the 1.0 milestone since it depends on when things land in Bazel. It is here for now for visibility on the roadmap for users.
The text was updated successfully, but these errors were encountered: