Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat: support core experimental versions ^0.28.0 #228

Merged
merged 14 commits into from
Jun 2, 2022
Merged

Conversation

blumamir
Copy link
Contributor

@blumamir blumamir commented May 26, 2022

fixes #220

@blumamir blumamir requested a review from a team as a code owner May 26, 2022 11:37
@rauno56
Copy link
Collaborator

rauno56 commented May 30, 2022

Great, I was just looking for this!

@blumamir
Copy link
Contributor Author

Great, I was just looking for this!

The CI currently fails about something with test-all-versions:

-- error installing ["socket.io-client@^4","socket.io@4.3.1"] (npm ERR! code ENOTEMPTY
npm ERR! syscall rename
npm ERR! path /home/runner/work/opentelemetry-ext-js/opentelemetry-ext-js/node_modules/ts-node
npm ERR! dest /home/runner/work/opentelemetry-ext-js/opentelemetry-ext-js/node_modules/.ts-node-lXLuC558
npm ERR! errno -39
npm ERR! ENOTEMPTY: directory not empty, rename '/home/runner/work/opentelemetry-ext-js/opentelemetry-ext-js/node_modules/ts-node' -> '/home/runner/work/opentelemetry-ext-js/opentelemetry-ext-js/node_modules/.ts-node-lXLuC558'

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2022-05-29T15_36_32_547Z-debug-0.log
) - retrying (2/10)...

✖ ERROR: Error: Cannot find module 'ts-node/register'

@rauno56 maybe you have an idea what the issue is? I am kind of lost on this one.

@rauno56
Copy link
Collaborator

rauno56 commented May 30, 2022

I saw that. I'm trying to repro...

@rauno56
Copy link
Collaborator

rauno56 commented May 31, 2022

Do you know the node version ubuntu-latest comes with? I have a feeling that npm@8 doesn't work with TAV anymore btw. I failed to install an older socket.io client after bootsraping by just running npm i socket.io@"^3" socket.io-client@"^3". npm@6(and node@14) works fine.

EDIT

It's node v16.15.0 (npm v8.5.5).

@blumamir
Copy link
Contributor Author

Do you know the node version ubuntu-latest comes with? I have a feeling that npm@8 doesn't work with TAV anymore btw. I failed to install an older socket.io client after bootsraping by just running npm i socket.io@"^3" socket.io-client@"^3". npm@6(and node@14) works fine.

EDIT

It's node v16.15.0 (npm v8.5.5).

Thanks for taking a look ❤️

I tried to run it with "ubuntu-18.04" (https://github.com/actions/virtual-environments#available-environments) and it also failed. Locally it's running fine on my machine npm 8.3.1 node v16.14.0

Tried to run only a subset of the tests in the hope it will supply a clue when this problem happens, but then run into lerna bugs 😂

When i examined CI runs, i noticed that it runs correctly on many packages and socket.io versions until it fails, but the fail happens on different socket.io versions and can sometimes fail after first retry of tav or second retry. So it smells like a race condition in the install sequence that tav is not handling correctly

@rauno56
Copy link
Collaborator

rauno56 commented Jun 1, 2022

Are TAV runs for different packages run in parallel? My assumption was that it was sequential.

@blumamir blumamir merged commit 6eaec0e into master Jun 2, 2022
@blumamir blumamir deleted the otel-core-28 branch June 2, 2022 14:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make instrumentations compatible with SDK 1.2.0/0.28.0
3 participants