Blazor: Decode URL segments in RouteContext #8759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Eilon
added
the
area-mvc
javiercn
reviewed
Apr 22, 2019
|
@javiercn have you looked at the latest update of this PR? What is pending here? |
|
I think this can be merged. |
|
Merged! Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
RouteContext, to URL-decode every route segment. This happens before they are matched inRouteEntry, so both static route segments and route parameters are handled.The current implementation of
TemplateParserseems pretty relaxed and only splits on the character/, so unless we want to support route segments containing escaped/characters, the change onRouteContextshould be enough.Addresses #5510