Skip to content
This repository has been archived by the owner on Jun 20, 2019. It is now read-only.

FREB: Usability: InternetStatus value should be set in Hex, not Decimal #199

Open
jhkimnew opened this issue Oct 18, 2017 · 4 comments
Open

FREB: Usability: InternetStatus value should be set in Hex, not Decimal #199

jhkimnew opened this issue Oct 18, 2017 · 4 comments
Assignees
@pan-wang
Labels
enhancement
Milestone
Backlog

Comments

@jhkimnew
Copy link
Contributor

Considering the InternetStatus code shows winhttp error code which is documented in hex number format, it will be nice if we use the Hex values in Freb log for easy comparison.
Currently we use decimal number like the below example.

...

  1. -ANCM_WINHTTP_CALLBACK

InternetStatus
4194304

0 ms
...
@shirhatti shirhatti added this to the 2.1.0-preview1 milestone Oct 18, 2017
@shirhatti
Copy link
Contributor

Let's do whatever is consistent with the rest of the IIS modules

@muratg muratg modified the milestones: 2.1.0-preview1, 2.1.0 Jan 18, 2018
@muratg
Copy link
Contributor

muratg commented Feb 17, 2018

@shirhatti should we carry FREB related issues to a single issue elsewhere?

@muratg
Copy link
Contributor

muratg commented Mar 5, 2018

Removing from preview2.

@shirhatti need to close this repo soon.

@muratg muratg removed this from the 2.1.0-preview2 milestone Mar 5, 2018
@muratg
Copy link
Contributor

muratg commented Mar 5, 2018

Removing from preview2.

@shirhatti need to close this repo soon.

@muratg muratg added this to the Backlog milestone Oct 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pan-wang pan-wang

Labels
enhancement
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@muratg @shirhatti @pan-wang @jhkimnew