Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should default(StringSegment) != default(StringSegment)? #111

Closed
tuespetre opened this issue May 12, 2016 · 5 comments
Closed

Should default(StringSegment) != default(StringSegment)? #111

tuespetre opened this issue May 12, 2016 · 5 comments
Milestone
1.1.0-preview1

Comments

@tuespetre
Copy link

I've noticed that default(StringSegment) == default(StringSegment) evaluates to false, which seems to be done for a reason in the source code, but I'm not sure what that reason is. I was just wondering if someone could fill me in, I'm just curious.
@pranavkm
Copy link

Seems like an oversight. cc @javiercn

@Eilon Eilon added bug labels May 12, 2016
@Eilon Eilon added this to the 1.0.0 milestone May 12, 2016
@Eilon Eilon added the help wanted Up for grabs. We would accept a PR to help resolve this issue label May 12, 2016
@Eilon
Copy link
Member

Eilon commented May 12, 2016

Yup this just seems like a bug.

@javiercn
Copy link
Member

Yep, @rynowak is there any perf reason to not do string.Compare directly? I've done a quick test of the API on the interactive window in VS and it works fine for null values. (We will want a theory test here, though)

@Eilon Eilon modified the milestones: 1.0.1, 1.0.0 May 17, 2016
@Eilon
Copy link
Member

Eilon commented Sep 29, 2016

@jbagga please enjoy this bug 😄

@Eilon
Copy link
Member

Eilon commented Sep 29, 2016

cc @pranavkm for FYI information.

@jbagga jbagga added 2 - Working and removed 1 - Ready help wanted Up for grabs. We would accept a PR to help resolve this issue labels Sep 29, 2016
@jbagga jbagga closed this as completed in 88d65b2 Sep 30, 2016
natemcmaster pushed a commit to natemcmaster/Extensions that referenced this issue Dec 4, 2018
@kirthik
Fix dotnet#111: Design changes to known/allowed culture list and cache
636459a
@ghost ghost locked as resolved and limited conversation to collaborators Dec 2, 2019
@ghost ghost unassigned jbagga Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0-preview1
Development

No branches or pull requests
5 participants
@pranavkm @Eilon @tuespetre @jbagga @javiercn