Skip to content
This repository has been archived by the owner on Nov 2, 2018. It is now read-only.

Turn on scope validation by default #481

Closed
danroth27 opened this issue Feb 10, 2017 · 7 comments
Closed

Turn on scope validation by default #481

danroth27 opened this issue Feb 10, 2017 · 7 comments

Comments

@danroth27
Copy link
Member

For 2.0 we should consider turning on scope validation by default.

@davidfowl
Copy link
Member

@pakrym before we turn this on by default need to look at the performance impact.

@davidfowl
Copy link
Member

Here's results from a benchmark I've added.

                       Method |        Mean |    StdErr |     StdDev |        Op/s | Scaled | Scaled-StdDev |  Gen 0 | Allocated |
----------------------------- |------------ |---------- |----------- |------------ |------- |-------------- |------- |---------- |
                    Transient |  43.5473 ns | 0.4130 ns |  2.2620 ns | 22963524.25 |   1.00 |          0.00 | 0.0095 |      24 B |
 TransientWithScopeValidation |  68.7545 ns | 1.3960 ns |  7.6460 ns | 14544498.22 |   1.58 |          0.19 | 0.0076 |      24 B |

@muratg
Copy link

muratg commented Apr 14, 2017

@danroth27 @DamianEdwards @Eilon do we want this on by default? Currently they can turn this on with a single line in program main.

If we want to turn this on by default, we'll need to do it across our tests firsts.

We were looking at this in DI triage with @davidfowl and @pakrym and we're not sure if this should be done.

@danroth27
Copy link
Member Author

It would be really nice if this was on by default, but we would need to test the perf impact.

@DamianEdwards
Copy link
Member

Perhaps we should just update the templates to have it on by default for Development only?

@muratg
Copy link

muratg commented Apr 17, 2017

@DamianEdwards that sounds reasonable to me. And we would also enable it at least for a portion of the tests, right?

@davidfowl
Copy link
Member

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants