Include scopeValidation race condition fix into a patch release

[pakrym]

#470 (comment)

/cc @Eilon @davidfowl @DamianEdwards

[Eilon]

Would this be for 1.0.x, 1.1.x, or both?

[henkmollema]

@Eilon this feature was added in 1.1 so no need for a patch in 1.0, I guess.

Personally I would like a patch release for this. We used this feature and hit the error (as mentioned here) so we had to disable it.

[Eilon]

Thanks, we'll evaluate this for the next patch release.

[Eilon]

This patch fix is approved. Please follow the normal code review / pull request process and make sure you make the change in the correct branch.

[pakrym]

Fixed in #513

[Eilon]

Preview builds of this patch fix should be available on the following feeds:

• https://dotnet.myget.org/gallery/aspnet-1-0-5-may2017-patch-public (for fixes in the 1.0.x release)
  • Feed URL to add to NuGet.config: https://dotnet.myget.org/F/aspnet-1-0-5-may2017-patch-public/api/v3/index.json
• https://dotnet.myget.org/gallery/aspnet-1-1-2-may2017-patch-public (for fixes in the 1.1.x release)
  • Feed URL to add to NuGet.config: https://dotnet.myget.org/F/aspnet-1-1-2-may2017-patch-public/api/v3/index.json

If you have a chance, please try out these preview builds and let us know if you have any feedback!

[henkmollema]

Awesome @Eilon, thanks! I'll try them out tomorrow.

[henkmollema]

@Eilon is it correct that there are no patch packages for Microsoft.AspNetCore.Mvc.Razor.ViewCompilation?

[Eilon]

@henkmollema there will be an update to that package, but I think only due to its dependencies (e.g. MVC) being updated. I don't think there are any actual functional fixes in that package.

[henkmollema]

@Eilon @pakrym I still hit some kind of race condition when enabling scope validation. I've created a repro here: https://github.com/henkmollema/DiConcurrencyBug.

/cc @davidfowl

[pakrym]

@henkmollema can you file a separate bug please, I'll investigate it today.

[henkmollema]

@pakrym done: #518.

[pakrym]

@henkmollema @Eilon This was caused by my mistake, fix was backported to a wrong branch and is not included in the build on the patch feed.

[pakrym]

I merged it to the right branch and verified that package built from it fixes the issue.

[henkmollema]

I see, thanks!

[henkmollema]

When can I expect these packages to show up at https://dotnet.myget.org/gallery/aspnet-1-1-2-may2017-patch-public?

[Eilon]

@henkmollema the builds happen automatically, and I see the last build was pushed about 3 hours ago. Can you try updating to see if you get the new packages?

[henkmollema]

@Eilon a bit late, but it works. Thanks!

[Eilon]

@henkmollema good to know, thanks!